Skip to content

[cupertino_ui] Fix example path#12151

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
dkwingsmt:fix-example-slash
Jul 11, 2026
Merged

[cupertino_ui] Fix example path#12151
auto-submit[bot] merged 1 commit into
flutter:mainfrom
dkwingsmt:fix-example-slash

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

A few example paths are not recognized by dartdoc for missing the initial slash.

This is the error log thrown by dartdoc before the PR:

  warning: example file not found: example/lib/magnifier/cupertino_text_magnifier.0.dart
    from magnifier.CupertinoTextMagnifier: (file:///Users/tongmu/dev/packages/packages/cupertino_ui/lib/src/magnifier.dart:39:7)
  warning: example file not found: example/lib/magnifier/cupertino_magnifier.0.dart
    from magnifier.CupertinoMagnifier: (file:///Users/tongmu/dev/packages/packages/cupertino_ui/lib/src/magnifier.dart:251:7)
  warning: example file not found: example/lib/magnifier/text_magnifier.0.dart
    from text_field.CupertinoTextField.magnifierConfiguration: (file:///Users/tongmu/dev/packages/packages/cupertino_ui/lib/src/text_field.dart:850:37)

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 8, 2026
@dkwingsmt dkwingsmt requested a review from Piinks July 8, 2026 21:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation comments in magnifier.dart and text_field.dart by adding a leading slash to the paths in the {@example} tags. There are no review comments, so no feedback is provided.

@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jul 8, 2026

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2026
@auto-submit auto-submit Bot merged commit b416a3b into flutter:main Jul 11, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants